Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rusty_v8 0.8.1 / V8 8.6.334 #6980

Merged
merged 3 commits into from
Aug 8, 2020
Merged

Upgrade to rusty_v8 0.8.1 / V8 8.6.334 #6980

merged 3 commits into from
Aug 8, 2020

Conversation

piscisaureus
Copy link
Member

No description provided.

piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
Upgrade to rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
9cc138a
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
Upgrade to rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
1fe56e5
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
ci: upgrade to Rust 1.45.2 (denoland#6980)
50ec354
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
Upgrade to rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
28b7529
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
ci: upgrade to Rust 1.45.2 (denoland#6980)
9915b0b
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
Upgrade to rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
5625ea5
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
fix(cli): show error for unrecognized V8 flags, exit on --help (denol…
34ae3b4 
…and#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
2bb5e69 
…d#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
upgrade: rust 1.45.2 (denoland#6980)
5fec366
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
upgrade: rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
f2c5e1f
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 7, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
1ac206f 
…d#6980)
@piscisaureus piscisaureus reopened this Aug 7, 2020
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
02dd12e 
…d#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
46b81f5 
…d#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
Revert "Change release build flags to optimize for size (denoland#6907)…
3ab7267 
…" (denoland#6980)

The non-default build (codegen) flags are applied only when building the
binary, however they are not used when building the tests. This makes
cargo recompile all crate dependencies and effectively doubles the time
to build and test in release mode.

Additionally when we were "watching" the benchmarks, this was likely a
meaningless activity as they too could have been built without these
alternative flags.

This reverts commit b7942bf.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
upgrade: rust 1.45.2 (denoland#6980)
48d3987
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
upgrade: rusty_v8 0.8.0 / V8 8.6.337 (denoland#6980)
6121c30
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
be3c666 
…d#6980)
@piscisaureus piscisaureus force-pushed the upgrade_rusty_v8 branch 3 times, most recently from 4148d87 to e44652b Compare August 8, 2020 14:02
@ry ry mentioned this pull request Aug 8, 2020
Merged
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
Revert "Change release build flags to optimize for size (denoland#6907)…
732dd4f 
…" (denoland#6980)

The non-default build (codegen) flags are applied only when building the
binary, however they are not used when building the tests. This makes
cargo recompile all crate dependencies and effectively doubles the time
to build and test in release mode.

Additionally when we were "watching" the benchmarks, this was likely a
meaningless activity as they too could have been built without these
alternative flags.

This reverts commit b7942bf.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
upgrade: rust 1.45.2 (denoland#6980)
f571c65
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
upgrade: rusty_v8 0.8.1 / V8 8.6.334 (denoland#6980)
77501b7
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/inspector_port_collision): fail rather than hang (denoland#6980
defdd99 
)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/inspector_port_collision): skip test on WSL (denoland#6980)
f2a9d9e
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/stat_test): older versions of Linux don't support birthtime (
9af8cc5 
denoland#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/wasm_unreachable): don't assume git work dir is named 'deno' (…
aa21d84 
…denoland#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
fix(cli): show error on unrecognized V8 flag, exit on --help (denolan…
f733880 
…d#6980)
@ry
Copy link
Member

ry commented Aug 8, 2020

-> #6990

@ry ry closed this Aug 8, 2020
@piscisaureus piscisaureus reopened this Aug 8, 2020
@piscisaureus piscisaureus changed the title Upgrade to rusty_v8 0.8.0 / V8 8.6.337 Upgrade to rusty_v8 0.8.1 / V8 8.6.334 Aug 8, 2020
ry
ry requested changes Aug 8, 2020
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
cli/main.rs Show resolved Hide resolved
cli/tests/integration_tests.rs Show resolved Hide resolved
cli/tests/integration_tests.rs Outdated Show resolved Hide resolved
cli/tests/integration_tests.rs Outdated Show resolved Hide resolved
cli/tests/unit/stat_test.ts Outdated
@@ -17,7 +17,8 @@ unitTest({ perms: { read: true } }, function fstatSyncSuccess(): void {
assert(fileInfo.size);
assert(fileInfo.atime);
assert(fileInfo.mtime);
assert(fileInfo.birthtime);
// The `birthtime` field is not available on Linux before kernel version 4.11.
assert(fileInfo.birthtime || Deno.build.os === "linux");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated

cli/tests/wasm_unreachable.out Outdated Show resolved Hide resolved
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/inspector_port_collision): fail rather than hang (denoland#6980
8d7317e 
)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/inspector_port_collision): skip test on WSL (denoland#6980)
a085098
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/stat_test): older versions of Linux don't support birthtime (
673d2f9 
denoland#6980)
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 8, 2020
@piscisaureus
test(cli/wasm_unreachable): don't assume git work dir is named 'deno' (…
1cdba52 
…denoland#6980)
ry
ry approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit a8b83db into denoland:master Aug 8, 2020
@piscisaureus piscisaureus deleted the upgrade_rusty_v8 branch August 8, 2020 20:09
@justjavac justjavac mentioned this pull request Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @ry