Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual error class to AssertionError message in assertThrows #4305

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Add actual error class to AssertionError message in assertThrows #4305

merged 1 commit into from
Mar 9, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Mar 9, 2020

Given the following code:

assertThrows(
  (): void => { fail("foo"); },
  MyError,
  "should throw MyError"
);

The original output was:

AssertionError: Expected error to be instance of "MyError".

With this change, the new output is:

AssertionError: Expected error to be instance of "MyError", but was "AssertionError".

ry
ry approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 2115b38 into denoland:master Mar 9, 2020
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8b
d9fc9c7 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8d
604b18e 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8e
76eeade 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8f
05b09c6 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8c
c74a276 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8g
3510074 
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@cknight
test: add actual error class to fail message (denoland/deno#4305)
8963e7a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight
test: add actual error class to fail message (denoland/deno#4305)
e18587c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
test: add actual error class to fail message (denoland/deno#4305)
9d74342
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
test: add actual error class to fail message (denoland/deno#4305)
9bd5945
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
test: add actual error class to fail message (denoland/deno#4305)
a812c61
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
test: add actual error class to fail message (denoland/deno#4305)
c530650
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
test: add actual error class to fail message (denoland/deno#4305)
e192cf7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @denobot
test: add actual error class to fail message (denoland/deno#4305)
e994c66
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@cknight @denobot
test: add actual error class to fail message (denoland/deno#4305)
5359984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknight @ry