Taking forward the Node fs polyfill #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ry ready for review. |
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 10, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294)
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incrementally moves the Node fs polyfill forward (ref #3403). In particular it implements the
appendFileandappendFileSyncfunctions.It looks like significant amounts of code will eventually be required to implement the full
fspolyfill. Therefore, I have started a new sub directory structure_fs, housing internal sub implementations offs, lestfs.tsget too big. This should makes things easier to write, test and review.Also added are
notImplementedimplementations ofaccessandaccessSync, which will possibly be close to implementing soon, but at least now we have code placeholders and a valid typescript API for them.Finally, there's an unrelated one character JSDoc fix inNevermind, someone else beat me to this.cli/js/lib.deno.ns.d.ts.