Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg: move JS ops implementations to cli/js/ops/, part 3 #4302

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

bartlomieju
Copy link
Member

Following JS ops were moved to separate files in cli/js/ops directory:

  • net
  • tls
  • fs

@bartlomieju bartlomieju changed the title [WIP] reorg: move JS ops implementations to cli/js/ops/, part 3 reorg: move JS ops implementations to cli/js/ops/, part 3 Mar 9, 2020
@bartlomieju bartlomieju requested a review from ry March 9, 2020 22:33
@bartlomieju
Copy link
Member Author

Ref #4248

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit b7eb241 into denoland:master Mar 9, 2020
@bartlomieju bartlomieju deleted the cli_js_ops3 branch March 9, 2020 23:22
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
  disable test_raw_tty (denoland#4282)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 10, 2020
* denoland/master:
  use Object instead of Map for promise table (denoland#4309)
  reorg: move js runtime tests to cli/js/tests/ (denoland#4250)
  upgrade: dprint 0.8.0 (denoland#4308)
  reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302)
  test: add actual error class to fail message (denoland#4305)
  upgrade: typescript 3.8.3 (denoland#4301)
  reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283)
  feat(std/node) add appendFile and appendFileSync (denoland#4294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants