Clean up how we use opIds #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Feb 25, 2020
bartlomieju
reviewed
Feb 25, 2020
ry
commented
Feb 25, 2020
| @@ -180,13 +180,15 @@ test(function sortingNonExistentParamRemovesQuestionMarkFromURL(): void { | |||
| assertEquals(url.search, ""); | |||
| }); | |||
|
|
|||
| /* | |||
| test(function customInspectFunction(): void { | |||
There was a problem hiding this comment.
For some unknown reason this test broke...
bartlomieju
approved these changes
Feb 25, 2020
Comment on lines
+392
to
+397
| if let Err(err) = r { | ||
| let s = format!("bad op id {}", err); | ||
| let msg = v8::String::new(scope, &s).unwrap(); | ||
| scope.isolate().throw_exception(msg.into()); | ||
| return; | ||
| } |
| if zero_copy.is_none() { | ||
| return futures::future::err(no_buffer_specified()).boxed_local(); | ||
| } | ||
| // TODO(ry) Probably poll_fn can be used here and the Write struct eliminated. |
Comment on lines
+196
to
+198
| if (OP_WRITE < 0) { | ||
| OP_WRITE = OPS_CACHE["op_write"]; | ||
| } |
There was a problem hiding this comment.
I still suggest to test this path using regular lookup, but that can be done as an experiment in separate PR
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Feb 26, 2020
* tag 'dm': (58 commits) Port permission_prompt_tests to Rust (denoland#4129) upgrade: TypeScript 3.8 (denoland#4100) Remove _async from method names since _sync are gone (denoland#4128) ci: Use fetch-depth: 5 (denoland#4127) fix: Resolve makeTemp* paths from CWD (denoland#4104) Clean up how we use opIds (denoland#4118) Fix issues with JavaScript importing JavaScript. (denoland#4120) fix: [http] Consume unread body and trailers before reading next request (denoland#3990) Remove ansi_term dependency (denoland#4116) port tools/repl_test.py to Rust (denoland#4096) Revert "Remove ansi_term dependency" fix: createSecKey logic (denoland#4063) Add Deno.Err change missing from previous commit (denoland#4113) rename Deno.Err -> Deno.errors (denoland#4093) doc: Remove old link to deno types output (denoland#4111) feat: Add Deno.formatDiagnostics (denoland#4032) disable std/examples/chat tests for windows (denoland#4109) update build instructions for windows (denoland#4027) Remove ansi_term dependency (denoland#4106) fix: add mutex guard for permission_prompt tests (denoland#4105) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch_assetshad two implementations: a binary and a JSON one. The JSON one was removed.fixes #4122