-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing opId gracefully #4122
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This has been coming up several times already; I need to finally fix it. The problem is that we use
unwrap
when trying to castopId
toUint32
- this panics ifopId
is undefined. Such situation should be handled gracefully by returning error to JS or adding assert onopId
inDeno.core.dispatch
- whichever will have smaller impact on performace.https://github.com/denoland/deno/pull/4118/checks?check_run_id=466535527
CC @ry
The text was updated successfully, but these errors were encountered: