Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve makeTemp* paths from CWD #4104

Merged
merged 6 commits into from
Feb 25, 2020
Merged

fix: Resolve makeTemp* paths from CWD #4104

merged 6 commits into from
Feb 25, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #4103.

@nayeemrmn
Copy link
Collaborator Author

nayeemrmn commented Feb 24, 2020 •
edited
Loading

TODO (not here): Move CWD resolution to the permission checking module. The underlying FS APIs we use don't need it to be resolved, it's just for permission checking. Then it can be tested reasonably.

Problem is it would lead to repeated resolution for the same path.

@ry
Copy link
Member

ry commented Feb 24, 2020

@nayeemrmn Nice - thanks! @Acerbic provided a nice test case https://github.com/Acerbic/deno_makedirtemp_bug_demo it would be great to get that in our tests.

@nayeemrmn
Copy link
Collaborator Author

Blocked by #4108.

@nayeemrmn nayeemrmn requested a review from ry February 24, 2020 19:03
ry
ry approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @nayeemrmn !

@ry ry merged commit 14e7e1e into denoland:master Feb 25, 2020
@nayeemrmn nayeemrmn deleted the make-temp-path-resolution branch February 25, 2020 18:39
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Feb 26, 2020
@dubiousjim
Merge tag 'dm' into work2.2
b145285 
* tag 'dm': (58 commits)
  Port permission_prompt_tests to Rust (denoland#4129)
  upgrade: TypeScript 3.8 (denoland#4100)
  Remove _async from method names since _sync are gone (denoland#4128)
  ci: Use fetch-depth: 5 (denoland#4127)
  fix: Resolve makeTemp* paths from CWD (denoland#4104)
  Clean up how we use opIds (denoland#4118)
  Fix issues with JavaScript importing JavaScript. (denoland#4120)
  fix: [http] Consume unread body and trailers before reading next request (denoland#3990)
  Remove ansi_term dependency (denoland#4116)
  port tools/repl_test.py to Rust (denoland#4096)
  Revert "Remove ansi_term dependency"
  fix: createSecKey logic (denoland#4063)
  Add Deno.Err change missing from previous commit (denoland#4113)
  rename Deno.Err -> Deno.errors (denoland#4093)
  doc: Remove old link to deno types output (denoland#4111)
  feat: Add Deno.formatDiagnostics (denoland#4032)
  disable std/examples/chat tests for windows (denoland#4109)
  update build instructions for windows (denoland#4027)
  Remove ansi_term dependency (denoland#4106)
  fix: add mutex guard for permission_prompt tests (denoland#4105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.makeTempDir permissions check bug with relative paths
2 participants
@nayeemrmn @ry