Refactor CLI entry point #2157
Refactor CLI entry point #2157
Conversation
bartlomieju
force-pushed
the
refactor_cli_entry_point
branch
from
6e2f8d9
to
172d927
Compare
| }).map_err(|(err, _worker)| print_err_and_exit(err)) | ||
| }); | ||
| tokio_util::run(main_future); | ||
| } |
There was a problem hiding this comment.
@ry PTAL at it. It seem that execute_mod_async does not evaluate and run file if prefetch is set to true, so simple letting worker finish the job seems to work fine. I'm not sure though
bartlomieju
force-pushed
the
refactor_cli_entry_point
branch
2 times, most recently
from
c51aed8
to
691aea7
Compare
bartlomieju
force-pushed
the
refactor_cli_entry_point
branch
from
691aea7
to
9d8c7d3
Compare
bartlomieju
force-pushed
the
refactor_cli_entry_point
branch
from
51c43e5
to
80ef15d
Compare
| } | ||
| ); | ||
| } | ||
| fn flags_from_vec(args: Vec<String>) -> DenoFlags { |
There was a problem hiding this comment.
I feel like this function should be the high level public “parse_flags” while the other function which is currently called “parse_flags” should be either combined into this or called something else (and be internal to this module)
There was a problem hiding this comment.
Yeah, I had similar feeling about it, but that means we no longer have matches var available in main(), that gives nice switch on matches.subcommand().
There was a problem hiding this comment.
Alternatively parse_flags may return DenoFlags, ArgMatches to handle both cases
|
The manual.md file also seems to need to be modified. |
|
PS we should add a "deno help" command - it feels like that would be expected now. |
|
@ry no problem, I can add it in an hour or so. I understand you want to add |
This PR refactors
main.rsto use dedicated functions for differentdeno <subcommand>, as discussed in #2084EDIT: This PR should be blocked by #2113
EDIT2: As suggested by @kevinkassimo in #2102 and changed
--typesand--prefetchto respective subcommands: