-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deno eval command #2102
Add deno eval command #2102
Conversation
Do a shortcut
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Looks good : )
As an aside should --types and --prefetch also be subcommands? (Perhaps prefetch could be "compile"...) |
@hayd yes I was thinking that too |
Just for disambiguation, I believe something like E.g.
(Since we have I also agree that we should promote
Personally believe this would make the functionalities much clearer. In this case, flags are more or less modifiers, which do not change the general behavior that subcommands dictate but decorate how to run and what to display. E.g. The following seems very clear to me about what kind of output to expect:
|
Thanks for the review guys. I do agree on having Adding all those subcommands would implicate refactor of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this will be great!
@bartlomieju you could also have --help and --version as hidden args, so they work as expected but aren't in the help text. |
This PR add
deno eval
command. Closes #2081At the moment it's a proof of concept.
Before merging this PR I'd like to land cleanup of CLI/flags as there's a lot of stutter in the code and it can be much cleaner.TODO: