Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement async module loading in CLI #2084

Merged
merged 9 commits into from
Apr 16, 2019
Merged

Implement async module loading in CLI #2084

merged 9 commits into from
Apr 16, 2019

Conversation

ry
Copy link
Member

@ry ry commented Apr 9, 2019 •
edited
Loading

Depends on #2082

Fixes #1769

@ry ry force-pushed the async_module_loading5 branch 6 times, most recently from ebca21e to 4bf4a57 Compare April 15, 2019 15:40
@ry ry requested a review from piscisaureus April 15, 2019 16:18
piscisaureus
piscisaureus reviewed Apr 16, 2019
View reviewed changes
core/modules.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 1bfb443 into denoland:master Apr 16, 2019
@ry ry mentioned this pull request Apr 16, 2019
Closed
@kevinkassimo
Copy link
Contributor

kevinkassimo commented Apr 16, 2019 •
edited
Loading

@ry #2021 broken after this patch:

$ ./target/release/deno --reload info https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/animation.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/ar.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/controls.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/environment.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/loading.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/magic-leap.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/staging.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/model-viewer-base.js?module
Downloading https://unpkg.com/three@^0.101.0?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/ModelScene.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/SmoothControls.js?module
Downloading https://unpkg.com/lit-element@^2.0.0?module
Downloading https://unpkg.com/lit-element@^2.0.0/lib/updating-element?module
Downloading https://unpkg.com/@google/[email protected]/lib/constants.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/template.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/Renderer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/utils.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/Model.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/StaticShadow.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/ARRenderer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/TextureUtils.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/WebGLUtils.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/assets/controls-svg.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/assets/view-in-ar-material-svg.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/EquirectangularToCubeGenerator.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/PMREMCubeUVPacker.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/PMREMGenerator.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/RGBELoader.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/EnvironmentMapGenerator.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/Reticle.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/CachingGLTFLoader.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/GLTFLoader.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/three-components/ModelUtils.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/third_party/three/Sky.js?module
Downloading https://unpkg.com/lit-html@^1.0.0?module
Downloading https://unpkg.com/lit-html@^1.0.0/lib/shady-render.js?module
Downloading https://unpkg.com/lib/updating-element.js?module
Downloading https://unpkg.com/lib/decorators.js?module
Downloading https://unpkg.com/lit-html@^1.0.0/lit-html.js?module
Downloading https://unpkg.com/lib/css-tag.js?module
Import 'https://unpkg.com/[email protected]/updating-element.js?module' failed: 404 Not Found
Import 'https://unpkg.com/[email protected]/updating-element.js?module' failed: 404 Not Found

Also

$ ./target/release/deno --reload info https://unpkg.com/three@^0.101.0?module
Downloading https://unpkg.com/three@^0.101.0?module
Downloading https://unpkg.com/three@^0.101.0?module
local: /Users/kun/Library/Caches/deno/deps/https/unpkg.com/[email protected]/build/three.module.js
type: JavaScript
panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:345:21
Abort trap: 6

@ry
Copy link
Member Author

ry commented Apr 16, 2019

@kevinkassimo ah cool thanks for the notice. I’ll try to get a unit test in core for it.

@somombo somombo mentioned this pull request Apr 17, 2019
Closed
@bartlomieju bartlomieju mentioned this pull request Apr 20, 2019
Merged
@ry ry mentioned this pull request May 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow relative module specifies that don't start with "./", "../", "/"
4 participants
@ry @kevinkassimo @piscisaureus @bartlomieju