feat(ext/web): add AbortSignal.any()
#21087
Conversation
|
@crowlKats please take a look |
| } | ||
|
|
||
| [remove](algorithm) { | ||
| this[abortAlgos] && SetPrototypeDelete(this[abortAlgos], algorithm); | ||
| } | ||
|
|
||
| constructor(key = null) { | ||
| if (key != illegalConstructorKey) { | ||
| if (key !== illegalConstructorKey) { | ||
| throw new TypeError("Illegal constructor."); | ||
| } | ||
| super(); | ||
| this[abortReason] = undefined; | ||
| this[abortAlgos] = null; |
There was a problem hiding this comment.
I think this is currently supposed to be an empty set on construction, see https://dom.spec.whatwg.org/#abortsignal-abort-algorithms. That should also cascade on a bunch of "null-check plus re-initialization" which may be redundant now.
There was a problem hiding this comment.
This was done for performance reasons in #12165, though not sure how ideal this is. I wouldn't worry about this though as it works as expected.
| throw new TypeError("Illegal constructor."); | ||
| } | ||
| super(); | ||
| this[abortReason] = undefined; | ||
| this[abortAlgos] = null; | ||
| this[dependent] = false; | ||
| this[sourceSignals] = null; | ||
| this[dependentSignals] = null; |
There was a problem hiding this comment.
I think in the specs these two are directly constructed as empty sets.
|
@petamoriken thanks for the PR! I had some local unfinished code related to this, so I left some drive-by comments in review. I'll leave the final review to @crowlKats, as he's overall more knowledgeable about this. |
|
@crowlKats please review |
Fixes #18944
Fixes #16487