Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Update lib.dom.d.ts with AbortSignal.any static method #22452

Closed
wants to merge 1 commit into from
Closed

Conversation

mblonyox
Copy link

Add typescript definition for AbortSignal.any() static method.

As #21087, the AbortSignal.any have been implemented but the typescript still doesn't detect the method.

Add typescript definition for AbortSignal.any() static method.

Signed-off-by: Sukirno <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

@petamoriken
Copy link
Contributor

Really? I think cli/tsc/dts/lib.dom.d.ts is cloned from TypeScript. I added AbortSignal.any type to ext/web/lib.deno_web.d.ts.

@mblonyox
Copy link
Author

I'm sorry I didn't know that the file cloned from the TypeScript definition. So I guess we just need to wait for typescript update in deno next release right?

@petamoriken
Copy link
Contributor

petamoriken commented Feb 17, 2024

For Deno it can already be handled by "lib": ["deno.window"] 😉

https://docs.deno.com/runtime/manual/advanced/typescript/configuration#using-the-lib-property

@petamoriken
Copy link
Contributor

If you want to use AbortSignal.any with "dom" type, you will have to wait for npm:@types/web. This includes types that APIs implemented in at least two browsers that automatically creates type files based on browser-compat-data. AbortSignal.any does not appear to be in it yet.

@mblonyox
Copy link
Author

If you want to use AbortSignal.any with "dom" type, you will have to wait for npm:@types/web. This includes types that APIs implemented in at least two browsers that automatically creates type files based on browser-compat-data. AbortSignal.any does not appear to be in it yet.

I've got it. Thank you for your explanation. I'm gonna close this PR.

@mblonyox mblonyox closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants