Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/web): add AbortSignal.any() #21087

Merged
merged 14 commits into from
Nov 13, 2023
Merged

feat(ext/web): add AbortSignal.any() #21087

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8110802
tweak
petamoriken Nov 3, 2023
a53d5dd
feat: add `AbortSignal.any`
petamoriken Nov 3, 2023
31e9e48
fix
petamoriken Nov 4, 2023
3ad837d
tweak
petamoriken Nov 4, 2023
0c4ba0b
add type
petamoriken Nov 4, 2023
0e21107
update wpt expectation.json
petamoriken Nov 4, 2023
83e5c10
fix
petamoriken Nov 4, 2023
b512831
fix
petamoriken Nov 4, 2023
0b4fa4c
tweak
petamoriken Nov 4, 2023
ffcdcff
Merge branch 'main' into feat/abortsignal-any
petamoriken Nov 4, 2023
ecb0f27
Merge branch 'main' into feat/abortsignal-any
petamoriken Nov 7, 2023
2071eb8
Update to `createDependentAbortSignal` from `follow`
petamoriken Nov 10, 2023
c4ac61f
Merge branch 'main' into feat/abortsignal-any
petamoriken Nov 10, 2023
efb9445
tweak
petamoriken Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tweak
  • Loading branch information
@petamoriken
petamoriken committed Nov 4, 2023
commit 81108027bbfb3fc079894c74a5b99fa75259f117
8 changes: 3 additions & 5 deletions ext/web/03_abort_signal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ class AbortSignal extends EventTarget {
if (this.aborted) {
return;
}
if (this[abortAlgos] === null) {
this[abortAlgos] = new SafeSet();
}
this[abortAlgos] ??= new SafeSet();
SetPrototypeAdd(this[abortAlgos], algorithm);
}

Expand All @@ -91,7 +89,7 @@ class AbortSignal extends EventTarget {

const event = new Event("abort");
setIsTrusted(event, true);
this.dispatchEvent(event);
super.dispatchEvent(event);
if (algos !== null) {
for (const algorithm of new SafeSetIterator(algos)) {
algorithm();
Expand All @@ -104,7 +102,7 @@ class AbortSignal extends EventTarget {
}

constructor(key = null) {
if (key != illegalConstructorKey) {
if (key !== illegalConstructorKey) {
throw new TypeError("Illegal constructor.");
}
super();
Expand Down