fix(node/http(s)): export globalAgent #21081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Hummer <[email protected]>
|
|
jcbhmr
changed the title
Signed-off-by: Jacob Hummer <[email protected]>
jcbhmr
changed the title
|
@bartlomieju you mentioned tests. how do i add tests? there's no obvious "polyfills/http_test.ts" or obvious file lol |
|
@jcbhmr You can add one in |
Signed-off-by: Jacob Hummer <[email protected]>
Signed-off-by: Jacob Hummer <[email protected]>
|
added tests. anything else i need to do? |
|
@jcbhmr CI is failing on format: https://github.com/denoland/deno/actions/runs/6800677587/job/18510257746?pr=21081 Can you run |
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
Fixes #21080 Fixes #18312 --------- Signed-off-by: Jacob Hummer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #21080
fix #18312