Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/http): export globalAgent #21082

Closed
wants to merge 1 commit into from
Closed

fix(node/http): export globalAgent #21082

wants to merge 1 commit into from

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Nov 3, 2023

fixes part of #18312

Signed-off-by: Jacob Hummer <[email protected]>
@jcbhmr jcbhmr changed the title fix(http): export globalAgent fix(node/http): export globalAgent Nov 3, 2023
@jcbhmr
Copy link
Contributor Author

jcbhmr commented Nov 3, 2023

this could hopefully fix @actions/http-client so that you can use it in Deno to write github actions related scripts in deno

https://www.npmjs.com/package/@actions/http-client?activeTab=code

image
image

@bartlomieju
Copy link
Member

Could we combine this PR with #21081 and add some basic unit tests that check that these are indeed exported?

@jcbhmr jcbhmr closed this Nov 7, 2023
@jcbhmr jcbhmr deleted the patch-2 branch November 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants