fix(node/http): export globalAgent (#21081)

Fixes #21080 Fixes #18312 --------- Signed-off-by: Jacob Hummer <[email protected]>
denoland · Nov 17, 2023 · f155ca7 · f155ca7
1 parent 407230f
commit f155ca7
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/cli/tests/unit_node/http_test.ts b/cli/tests/unit_node/http_test.ts
@@ -812,3 +812,27 @@ Deno.test(
  await server.finished;
  },
 );
+
+Deno.test("[node/http] node:http exports globalAgent", async () => {
+ const http = await import("node:http");
+ assert(
+ http.globalAgent,
+ "node:http must export 'globalAgent' on module namespace",
+ );
+ assert(
+ http.default.globalAgent,
+ "node:http must export 'globalAgent' on module default export",
+ );
+});
+
+Deno.test("[node/https] node:https exports globalAgent", async () => {
+ const https = await import("node:https");
+ assert(
+ https.globalAgent,
+ "node:https must export 'globalAgent' on module namespace",
+ );
+ assert(
+ https.default.globalAgent,
+ "node:https must export 'globalAgent' on module default export",
+ );
+});
diff --git a/ext/node/polyfills/http.ts b/ext/node/polyfills/http.ts
@@ -1764,13 +1764,15 @@ export function get(...args: any[]) {
 export {
  Agent,
  ClientRequest,
+ globalAgent,
  IncomingMessageForServer as IncomingMessage,
  METHODS,
  OutgoingMessage,
  STATUS_CODES,
 };
 export default {
  Agent,
+ globalAgent,
  ClientRequest,
  STATUS_CODES,
  METHODS,

diff --git a/ext/node/polyfills/https.ts b/ext/node/polyfills/https.ts
@@ -104,7 +104,7 @@ export class Agent extends HttpAgent {
  }
 }
 
-const globalAgent = new Agent({
+export const globalAgent = new Agent({
  keepAlive: true,
  scheduling: "lifo",
  timeout: 5000,