fix(ops): fallback when FastApiOneByteString is not utf8 #18518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Mar 31, 2023
| Ok(v) => v, | ||
| Err(_) => { | ||
| unsafe { &mut *fast_api_callback_options }.fallback = true; | ||
| return Default::default(); |
There was a problem hiding this comment.
If memory serves, I had to do a separate default return value for pointer returning since there's no Default impl for a void pointer.
aapoalas
reviewed
Mar 31, 2023
| }), | ||
| StringType::Cow => q!(Vars { var: &ident }, { | ||
| let var = ::std::borrow::Cow::Borrowed(unsafe { &*var }.as_str()); | ||
| let var = ::std::borrow::Cow::Borrowed( | ||
| match ::std::str::from_utf8(unsafe { &*var }.as_bytes()) { |
There was a problem hiding this comment.
Would it be possible to avoid doing the V8 fallback, and instead just create a String copy conditionally from the bytes?
bartlomieju
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18255
Depends on denoland/rusty_v8#1206