Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ops): fallback when FastApiOneByteString is not utf8 #18518

Merged
merged 4 commits into from
Mar 31, 2023
Merged

fix(ops): fallback when FastApiOneByteString is not utf8 #18518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
096bef7
fix(ops): fallback when FastApiOneByteString is not utf8
littledivy Mar 31, 2023
be81112
Merge branch 'main' of github.com:denoland/deno into fastops_utf8_val…
littledivy Mar 31, 2023
5e3a9ad
update tests
littledivy Mar 31, 2023
0af9c6d
Fix
littledivy Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:denoland/deno into fastops_utf8_val… 
…idate
  • Loading branch information
@littledivy
littledivy committed Mar 31, 2023
commit be811127faf2cb5725bf4c43402b8a8f488cbff7
19 changes: 0 additions & 19 deletions ops/optimizer_tests/cow_str.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,25 +73,6 @@ impl op_cow_str {
op_state.tracker.track_sync(ctx.id);
}
}
struct op_cow_str_fast {
_phantom: ::std::marker::PhantomData<()>,
}
impl<'scope> deno_core::v8::fast_api::FastFunction for op_cow_str_fast {
#[inline(always)]
fn function(&self) -> *const ::std::ffi::c_void {
op_cow_str_fast_fn as *const ::std::ffi::c_void
}
#[inline(always)]
fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
use deno_core::v8::fast_api::Type::*;
use deno_core::v8::fast_api::CType;
&[V8Value, SeqOneByteString, CallbackOptions]
}
#[inline(always)]
fn return_type(&self) -> deno_core::v8::fast_api::CType {
deno_core::v8::fast_api::CType::Void
}
}
#[allow(clippy::too_many_arguments)]
fn op_cow_str_fast_fn<'scope>(
_: deno_core::v8::Local<deno_core::v8::Object>,
Expand Down
19 changes: 0 additions & 19 deletions ops/optimizer_tests/owned_string.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,25 +85,6 @@ impl op_string_length {
};
}
}
struct op_string_length_fast {
_phantom: ::std::marker::PhantomData<()>,
}
impl<'scope> deno_core::v8::fast_api::FastFunction for op_string_length_fast {
#[inline(always)]
fn function(&self) -> *const ::std::ffi::c_void {
op_string_length_fast_fn as *const ::std::ffi::c_void
}
#[inline(always)]
fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
use deno_core::v8::fast_api::Type::*;
use deno_core::v8::fast_api::CType;
&[V8Value, SeqOneByteString, CallbackOptions]
}
#[inline(always)]
fn return_type(&self) -> deno_core::v8::fast_api::CType {
deno_core::v8::fast_api::CType::Uint32
}
}
#[allow(clippy::too_many_arguments)]
fn op_string_length_fast_fn<'scope>(
_: deno_core::v8::Local<deno_core::v8::Object>,
Expand Down
19 changes: 0 additions & 19 deletions ops/optimizer_tests/strings.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,25 +86,6 @@ impl op_string_length {
};
}
}
struct op_string_length_fast {
_phantom: ::std::marker::PhantomData<()>,
}
impl<'scope> deno_core::v8::fast_api::FastFunction for op_string_length_fast {
#[inline(always)]
fn function(&self) -> *const ::std::ffi::c_void {
op_string_length_fast_fn as *const ::std::ffi::c_void
}
#[inline(always)]
fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
use deno_core::v8::fast_api::Type::*;
use deno_core::v8::fast_api::CType;
&[V8Value, SeqOneByteString, CallbackOptions]
}
#[inline(always)]
fn return_type(&self) -> deno_core::v8::fast_api::CType {
deno_core::v8::fast_api::CType::Uint32
}
}
#[allow(clippy::too_many_arguments)]
fn op_string_length_fast_fn<'scope>(
_: deno_core::v8::Local<deno_core::v8::Object>,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.