Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastApiOneByteString is not always utf-8 #1206

Merged
merged 2 commits into from
Mar 31, 2023
Merged

FastApiOneByteString is not always utf-8 #1206

merged 2 commits into from
Mar 31, 2023

Conversation

littledivy
Copy link
Member

This commit removes the as_str() method and adds the as_bytes method to access the Latin-1 data. The utf8 assumption is wrong, the application should validate before converting to Rust string.

@littledivy littledivy mentioned this pull request Mar 31, 2023
Merged
aapoalas
aapoalas approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@littledivy littledivy enabled auto-merge (squash) March 31, 2023 07:28
@littledivy littledivy merged commit fe7610a into denoland:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littledivy @lucacasonato @aapoalas