Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because ESM does not support
export =
assignments, nor allow "spreading" of exports, JSON modules when targeting ESM need to use aexport default
. From a type checking perspective, though, TypeScript assumes JSON modules will be anexport =
affair, even when targeting ESM as the output. This means we to add theesModuleInterop
flag to the compiler options. This doesn't change the emit, but allows TypeScript to assume that the default import of a module is the same as the namespace import.This does mean that to properly import JSON modules, we have no option but to deal with the default import, so instead of:
Only the following is supported:
This currently includes #1512 as well, which I will rebase when that is merged.Rebased and ready. @ry