Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup compiler and re-enable tests #1512

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Cleanup compiler and re-enable tests #1512

merged 1 commit into from
Jan 14, 2019

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jan 13, 2019

Resolves #1488

This cleans up enough to be able to take a look at some of the duplicate loading issues and break the compiler out to its own image.

ry
ry reviewed Jan 13, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 4 files changed, 121 insertions(+), 299 deletions(-)

Nice clean up!

js/compiler_test.ts Show resolved Hide resolved
@kitsonk kitsonk mentioned this pull request Jan 14, 2019
Merged
ry
ry approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit de9c67a into denoland:master Jan 14, 2019
@kitsonk kitsonk deleted the post-esm branch August 2, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kitsonk @ry