Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media_types running under Deno with ESM #113

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Fix media_types running under Deno with ESM #113

merged 2 commits into from
Jan 15, 2019

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jan 14, 2019

Fixes the importing of JSON. Requires a build of Deno that includes denoland/deno#1514 (e.g. current master).

Upgrading to a version of Deno that includes ESM will "break" media_types and the other patch and this one will "fix" it.

@ry
Copy link
Member

ry commented Jan 15, 2019

With v0.2.7, I'm also getting an error which seems related:

assertEqual failed. actual = text/plain expected = text/yaml... FAILED
Error: actual: text/plain expected: text/yaml
    at assertEqual (/Users/rld/src/deno_std/testing/mod.ts:23:15)
    at serveFile (/Users/rld/src/deno_std/http/file_server_test.ts:20:9)

@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 15, 2019

@ry I will take a look

@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 15, 2019

@ry I cannot reproduce locally... off of master, against this PR:

test serveFile [2019-01-15 06:07:39] "GET /azure-pipelines.yml HTTP/1.1" 200
... ok

If there are things cached locally for some reason, it could throw this off. I will update the PR to bump the version of Deno.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for looking - must be somebthng on my side.

@ry ry merged commit 77b3391 into denoland:master Jan 15, 2019
@ry ry mentioned this pull request Jan 15, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants