refactor(core): Move Deno.core bindings to ops #14793
Conversation
There was a problem hiding this comment.
Great work overall, pretty much what I had in mind following #14582
However I would suggest the following changes for this first pass:
- Scope changes to
core/, have outside callers still useDeno.core.foo()by adding light wrappers in01_core.js. - Keep the "v8 ops" separate from the other "regular ops", e.g: in an
ops_v8.rsorops_builtin_v8.rsor just in bindings for now
Okay, I added wrappers for the ones used in std but it's fairer to do it with all of them after all :-) I think in a couple of versions we should remove all of those basic wrappers, including existing |
Both |
| @@ -1,4 +1,5 @@ | |||
| [WILDCARD]error: Uncaught Error: foo | |||
| Warning Couldn't format source line: Column 31 is out of bounds (source may have changed at runtime) | |||
| at file:https:///[WILDCARD]/eval_context_conflicting_source.ts:1:31 | |||
| at [WILDCARD] | |||
There was a problem hiding this comment.
There's a new stack frame for opSync
| @@ -205,7 +205,7 @@ | |||
| const transferables = []; | |||
| const hostObjects = []; | |||
| const arrayBufferIdsInTransferables = []; | |||
| const transferedArrayBuffers = []; | |||
There was a problem hiding this comment.
These are technically unrelated, but thanks for fixing it
|
Blocked by update after #14604 was merged |
Move most
Deno.corebindings which are defined in Rust to ops e.g.Deno.core.encode(foo)->Deno.core.opSync("op_encode", foo)using#[op(v8)]. Ref #14574, #14582. One more change to the macro was required to avoid late-bound lifetime parameters when returning a value with a lifetime compatible based onscope's.The following which are used in std are preserved as wrappers in
01_core.js, we should deprecate this syntax and update them to ops:Deno.core.setMacrotaskCallback()Deno.core.setNextTickCallback()Deno.core.runMicrotasks()Deno.core.hasTickScheduled()Deno.core.setHasTickScheduled()Deno.core.evalContext()Deno.core.encode()