Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Format non-error exceptions #14604

Merged
merged 10 commits into from
Jun 6, 2022

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #14596.

@bartlomieju bartlomieju added this to the 1.23 milestone Jun 1, 2022
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nayeem

@bartlomieju bartlomieju merged commit e3eae66 into denoland:main Jun 6, 2022
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 6, 2022
This commit adds "Deno.core.setFormatExceptionCallback" which
can be used to provide custom formatting for errors. It is useful
in cases when user throws something that is non-Error (eg.
a string, plain object, etc).
@nayeemrmn nayeemrmn deleted the format-non-error-exceptions branch June 7, 2022 09:52
cjihrig pushed a commit that referenced this pull request Jun 9, 2022
This commit adds "Deno.core.setFormatExceptionCallback" which
can be used to provide custom formatting for errors. It is useful
in cases when user throws something that is non-Error (eg.
a string, plain object, etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.test does not render POJO errors nicely
2 participants