Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ops): allow passing scope handle to sync ops #14574

Merged
merged 1 commit into from
May 12, 2022
Merged

feat(ops): allow passing scope handle to sync ops #14574

merged 1 commit into from
May 12, 2022

Conversation

littledivy
Copy link
Member

To be able to leverage serde_v8::Value APIs (as required in #14556)

@littledivy littledivy requested a review from AaronO as a code owner May 12, 2022 03:32
bartlomieju
bartlomieju approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be great if you added a test for this change

@littledivy
Copy link
Member Author

LGTM, would be great if you added a test for this change

Opened an issue to add compile tests for the proc macro #14577

@littledivy littledivy merged commit 3166506 into denoland:main May 12, 2022
@nayeemrmn nayeemrmn mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@AaronO AaronO Awaiting requested review from AaronO

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju