fix(ext/crypto): adjust getRandomValues types
#14714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkldshv
requested review from
lucacasonato,
littledivy and
bartlomieju
as code owners
darvesh
reviewed
May 24, 2022
mrkldshv
changed the title
BigUint64Array to getRandomValuesgetRandomValues types
mrkldshv
force-pushed
the
bugfix/crypto-random-uint64-arr
branch
from
ec2f131
to
b810e03
Compare
bartlomieju
approved these changes
May 31, 2022
There was a problem hiding this comment.
LGTM, but I'll wait for @lucacasonato approval before merging.
littledivy
approved these changes
Jun 2, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Jun 2, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
BigInt64Array,BigUint64Arrayand removeFloat32Array,Float64Arraytypes from cryptogetRandomValues.Closes #14710.