fix(ext/crypto): adjust getRandomValues types (#14714)

denoland · Jun 2, 2022 · 5eef49c · 5eef49c
1 parent 9f7e314
commit 5eef49c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/cli/tests/unit/get_random_values_test.ts b/cli/tests/unit/get_random_values_test.ts
@@ -37,12 +37,24 @@ Deno.test(function getRandomValuesInt32Array() {
  assertNotEquals(arr, new Int32Array(8));
 });
 
+Deno.test(function getRandomValuesBigInt64Array() {
+ const arr = new BigInt64Array(8);
+ crypto.getRandomValues(arr);
+ assertNotEquals(arr, new BigInt64Array(8));
+});
+
 Deno.test(function getRandomValuesUint32Array() {
  const arr = new Uint32Array(8);
  crypto.getRandomValues(arr);
  assertNotEquals(arr, new Uint32Array(8));
 });
 
+Deno.test(function getRandomValuesBigUint64Array() {
+ const arr = new BigUint64Array(8);
+ crypto.getRandomValues(arr);
+ assertNotEquals(arr, new BigUint64Array(8));
+});
+
 Deno.test(function getRandomValuesReturnValue() {
  const arr = new Uint32Array(8);
  const rtn = crypto.getRandomValues(arr);

diff --git a/ext/crypto/lib.deno_crypto.d.ts b/ext/crypto/lib.deno_crypto.d.ts
@@ -326,8 +326,8 @@ declare interface Crypto {
  | Uint16Array
  | Uint32Array
  | Uint8ClampedArray
- | Float32Array
- | Float64Array
+ | BigInt64Array
+ | BigUint64Array
  | DataView
  | null,
  >(