Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): adjust getRandomValues types #14714

Merged
merged 7 commits into from
Jun 2, 2022
Merged

fix(ext/crypto): adjust getRandomValues types #14714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4539aa9
fix: add `BigUint64Array` to crypto `getRandomValues`
mrkldshv May 24, 2022
b810e03
fix: add `BigInt64Array` and remove `Float32Array`, `Float64Array`
mrkldshv May 25, 2022
a9d73f2
Merge branch 'main' into bugfix/crypto-random-uint64-arr
bartlomieju May 31, 2022
24dd708
Merge branch 'main' into bugfix/crypto-random-uint64-arr
bartlomieju Jun 1, 2022
edd6257
Merge branch 'main' into bugfix/crypto-random-uint64-arr
bartlomieju Jun 1, 2022
5c1040d
Merge branch 'main' into bugfix/crypto-random-uint64-arr
littledivy Jun 2, 2022
2632487
Merge branch 'main' into bugfix/crypto-random-uint64-arr
littledivy Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cli/tests/unit/get_random_values_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,24 @@ Deno.test(function getRandomValuesInt32Array() {
assertNotEquals(arr, new Int32Array(8));
});

Deno.test(function getRandomValuesBigInt64Array() {
const arr = new BigInt64Array(8);
crypto.getRandomValues(arr);
assertNotEquals(arr, new BigInt64Array(8));
});

Deno.test(function getRandomValuesUint32Array() {
const arr = new Uint32Array(8);
crypto.getRandomValues(arr);
assertNotEquals(arr, new Uint32Array(8));
});

Deno.test(function getRandomValuesBigUint64Array() {
const arr = new BigUint64Array(8);
crypto.getRandomValues(arr);
assertNotEquals(arr, new BigUint64Array(8));
});

Deno.test(function getRandomValuesReturnValue() {
const arr = new Uint32Array(8);
const rtn = crypto.getRandomValues(arr);
Expand Down
4 changes: 2 additions & 2 deletions ext/crypto/lib.deno_crypto.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ declare interface Crypto {
| Uint16Array
| Uint32Array
| Uint8ClampedArray
| Float32Array
| Float64Array
| BigInt64Array
| BigUint64Array
mrkldshv marked this conversation as resolved.
Show resolved Hide resolved
| DataView
| null,
>(
Expand Down