Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo publish fails without absolute paths #13993

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

ry
Copy link
Member

@ry ry commented Mar 16, 2022

4e3ed37 was erroneous and broke cargo publish. I've opened #13994 that would allow us to catch errors like this in the future.

1.20.1 will be released after this is landed.

@ry ry requested a review from bartlomieju as a code owner March 16, 2022 22:13
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the trouble

@ry ry requested a review from piscisaureus as a code owner March 16, 2022 23:54
@bartlomieju bartlomieju merged commit f7ab415 into denoland:main Mar 17, 2022
@ry ry deleted the fix-cli-build branch March 17, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants