Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve build times for ext/ changes #13927

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Mar 12, 2022

Time spent for a trivial change in ext/crypto:

main:
Screenshot 2022-03-12 at 7 49 58 PM

This PR:
Screenshot 2022-03-12 at 7 50 28 PM

Skips running deno (build.rs) when it's not needed by removing extension crates as its build dependency.

@bartlomieju
Copy link
Member

Looks great, did you verify that snapshots are properly rebuilt when JS code changes in any of the ext/ crates?

@littledivy
Copy link
Member Author

Looks great, did you verify that snapshots are properly rebuilt when JS code changes in any of the ext/ crates?

Yup

@@ -78,22 +78,33 @@ fn create_compiler_snapshot(
) {
// libs that are being provided by op crates.
let mut op_crate_libs = HashMap::new();
op_crate_libs.insert("deno.console", deno_console::get_declaration());
op_crate_libs.insert("deno.url", deno_url::get_declaration());
op_crate_libs.insert("deno.web", deno_web::get_declaration());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems these get_declaration methods could now be removed

@littledivy littledivy merged commit 4e3ed37 into denoland:main Mar 14, 2022
@littledivy littledivy deleted the less_bloat branch March 14, 2022 03:38
ry added a commit to ry/deno that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants