Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should do cargo publish --dry-run #13994

Open
ry opened this issue Mar 16, 2022 · 1 comment
Open

CI should do cargo publish --dry-run #13994

ry opened this issue Mar 16, 2022 · 1 comment
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Mar 16, 2022

Doing it for each of the crates sounds very expensive (but necessary to catch all errors, I think).

We should at minimum do it for the CLI crate...
@ry ry added the build build system or continuous integration related label Mar 16, 2022
@ry ry mentioned this issue Mar 16, 2022
Merged
@dsherret dsherret mentioned this issue Mar 17, 2022
Merged
@dsherret
Copy link
Member

dsherret commented Mar 24, 2022 •
edited

I looked into this today in #13995 and it doesn't look possible to do this for when one crate depends on another unpublished crate at the moment. Seems like rust-lang/cargo#1169 is the issue to follow that could make this possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system or continuous integration related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @dsherret