Ensure global type instances are available.

[kitsonk]

Fixes #1173

It also cleans up a few things related to the globals.ts and provides more comments to help guide additions to the file.

[ry]

Thanks for the fix ! Can you also add the test case I gave in the issue

[kitsonk]

@ry done

[bartlomieju]

doing that won't cause window to miss all properties assigned to it in globals.ts? I think we would like to use most of them in REPL

[ry]

Valid question ... However, I'm going to land this anyway because I need the fix and because this is passing the tests. If this indeed breaks window properties, we should add tests that nail that behavior down.

[bartlomieju]

It doesn't just rebased it against my REPL branch and everything works as expected.

[kitsonk]

At compile/bundle time this ends up being an any, even when you do import { window } from "./globals.ts"; (because that reference is the same globalEval("this");. At runtime we build the type library which describes what the global scope is, and the ability to access the globalEval module isn't possible. I had previously thought about tightening compile time typings of globalEval("this"); which could be done, but it would be difficult and not really provide any safety, as most of what we do with it is cast it to any anyways.

[ry]

LGTM