Local filenames starting with 'http' shouldn't be remote. #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"http_test.ts" was being marked as a remote module specifier.
kitsonk
reviewed
Nov 7, 2018
| const ASSET_PREFIX: &str = "/$asset$/"; | ||
|
|
||
| fn is_remote(module_name: &str) -> bool { | ||
| module_name.starts_with("http") | ||
| module_name.starts_with("http:https://") || module_name.starts_with("https://") |
There was a problem hiding this comment.
Though we don't support it ATM, would any URI with a protocol be a better test here, a RegEx of /^\S+:\/{2}/? That would trap file:https:// as well, but we don't handle that yet anyways.
There was a problem hiding this comment.
Ya let’s wait until we support other protocols. I think this function goes away completely in #1039 anyway.
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 12, 2018
- Update to TypeScript 3.1.6 (denoland#1177) - Fixes Headers type not available. (denoland#1175) - Reader/Writer to use Uint8Array not ArrayBufferView (denoland#1171) - Fixes importing modules starting with 'http'. (denoland#1167) - build: Use target/ instead of out/ (denoland#1153) - Support repl multiline input (denoland#1165)
Merged
ry
added a commit
that referenced
this pull request
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"http_test.ts" was being marked as a remote module specifier.