Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Use target/ instead of out/ #1153

Merged
merged 3 commits into from
Nov 8, 2018
Merged

build: Use target/ instead of out/ #1153

merged 3 commits into from
Nov 8, 2018

Conversation

ry
Copy link
Member

@ry ry commented Nov 5, 2018

No description provided.

@ry ry requested a review from piscisaureus November 5, 2018 03:47
@piscisaureus
Copy link
Member

Not sure what the motivation for this is.
The output structure in out/debug is quite different from target/debug, this are not magically going to work together.
I'm not against it btw - I'm just curious why you think this is better.

@ry
Copy link
Member Author

ry commented Nov 6, 2018

It’s just a step closer - rather than having two differently named output directories we have one

@piscisaureus
Copy link
Member

Ok +1 but do the switch more thoroughly. There's a bunch of unexpected places where there's a dependency on 'out', e.g. in tsconfig.json, and it's mentioned in the docs a couple of times too.

@ry ry merged commit a18e51f into denoland:master Nov 8, 2018
ry added a commit to ry/deno that referenced this pull request Nov 12, 2018
@ry
v0.1.12
833b39a 
- Update to TypeScript 3.1.6 (denoland#1177)
- Fixes Headers type not available. (denoland#1175)
- Reader/Writer to use Uint8Array not ArrayBufferView (denoland#1171)
- Fixes importing modules starting with 'http'. (denoland#1167)
- build: Use target/ instead of out/ (denoland#1153)
- Support repl multiline input (denoland#1165)
@ry ry mentioned this pull request Nov 12, 2018
Merged
ry added a commit that referenced this pull request Nov 12, 2018
@ry
v0.1.12
0c740ff 
- Update to TypeScript 3.1.6 (#1177)
- Fixes Headers type not available. (#1175)
- Reader/Writer to use Uint8Array not ArrayBufferView (#1171)
- Fixes importing modules starting with 'http'. (#1167)
- build: Use target/ instead of out/ (#1153)
- Support repl multiline input (#1165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus