Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/dts): stricter typings for Listener & Conn #10012

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

crowlKats
Copy link
Member

Closes #5477

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should not be breaking due to the type argument having a default type.

@kitsonk PTAL too

@lucacasonato lucacasonato added the public API related to "Deno" namespace in JS label Apr 5, 2021
@lucacasonato lucacasonato added this to the 1.9.0 milestone Apr 5, 2021
@bartlomieju bartlomieju requested a review from kitsonk April 8, 2021 14:38
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@bartlomieju bartlomieju merged commit a8057e3 into denoland:main Apr 13, 2021
@crowlKats crowlKats deleted the listen_addr branch April 13, 2021 15:26
kitsonk added a commit to kitsonk/deno that referenced this pull request Apr 19, 2021
kitsonk added a commit that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public API related to "Deno" namespace in JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.Listener no exposing port
4 participants