feat(net): getAvailablePort()
#3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please create a file for each API with corresponding file name, and re-export them from |
|
Also please write some test for each API |
kt3k
reviewed
Dec 2, 2023
kt3k
reviewed
Dec 2, 2023
net/port.ts
Outdated
| * @param ms the duration of the intervals between re-checking readiness | ||
| * @throws if the inner `Deno.connect` call throws a non `Deno.errors.ConnectionRefused` error. | ||
| */ | ||
| export async function ready(port: number, ms = 500): Promise<void> { |
There was a problem hiding this comment.
Let's make the second argument option object. We probably would like to add more options in the future (e.g. signal: AbortSignal, timeout: number. etc)
There was a problem hiding this comment.
I got rid of this function altogether. I think iuioiua's comment about using retry is correct (even moreso in light of mention of abort behavior / ie. would the function throw?).
iuioiua
approved these changes
Dec 3, 2023
net/get_available_port_test.ts
Outdated
| Deno.test("getAvailablePort() gets an available port", async () => { | ||
| const port = getAvailablePort(); | ||
|
|
||
| assert(port > 0); |
iuioiua
approved these changes
Dec 4, 2023
kt3k
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3279