Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): Implement textDocument/prepareCallHierarchy #10061

Merged
merged 7 commits into from
Apr 19, 2021
Merged

feat(lsp): Implement textDocument/prepareCallHierarchy #10061

merged 7 commits into from
Apr 19, 2021

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Apr 7, 2021

Also implements callHierarchy/incomingCalls and callHierarchy/outgoingCalls

Related #8643

@jeanp413
Copy link
Contributor Author

jeanp413 commented Apr 8, 2021

Don't know why my test is failing in the CI, it runs fine locally, any ideas?

@lucacasonato
Copy link
Member

lucacasonato commented Apr 8, 2021 •
edited
Loading

cc @kt3k for the CI failure - seems to be related to caching

@kitsonk kitsonk self-requested a review April 8, 2021 12:08
@bartlomieju bartlomieju added this to the 1.10.0 milestone Apr 16, 2021
kitsonk
kitsonk reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment... thanks for all your contributions.

cli/lsp/tsc.rs Show resolved Hide resolved
kitsonk
kitsonk approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 65a2a04 into denoland:main Apr 19, 2021
@kitsonk kitsonk mentioned this pull request Apr 19, 2021
Closed
43 tasks
@jeanp413 jeanp413 deleted the lsp-call-hierarchy branch April 19, 2021 13:50
kitsonk added a commit that referenced this pull request Apr 20, 2021
@kitsonk
revert: Conn type changes in #10012 and #10061 (#10255)
b6203cb 
Fixes #10200 (again)

This reverts commit 9c7c9a3 and a8057e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeanp413 @lucacasonato @kitsonk @bartlomieju @kt3k