-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't build master #3153
Comments
Could you try to |
@chrmoritz Just tried that out and it failed in the same way |
@jamiebuilds Try |
@ry Just tried that too, still failing with
|
@jamiebuilds Can you examine your |
I don't keep any keys in my env right now. But I do have my local copy of
I also tried grepping around |
@jamiebuilds Would you mind trying to edit your path so it doesn't have that depot_tools and see if that is the problem? (We provide our own copy of depot_tools in third_party/depot_tools) |
@ry Yeah, I did that when I saw it was there and got the same result. |
@jamiebuilds Oops sorry I missed that. So to give you some context, "cargo build" is running core/build.rs which is failing on line 94, trying to run "tools/setup.py" Lines 85 to 94 in 1f52c66
tool/setup.py fetches some binary dependencies from Google Cloud Storage - it seems to be failing trying to get clang_format . It might be helpful if you just ran "tools/setup.py" by itself and see if there is a better error message.
One annoying thing is that clang_format isn't even required to build deno - it's just for people submitting changes and running tools/format.py ... but that's tangental. @chrmoritz any ideas? |
Output of
|
Oh wait, I can now reproduce the same error locally too (with a clean checkout) and I'm sure everything was fine a few days ago. Given that the erroring code lives in |
I am on macOS Catalina if that is relevant. |
The way to reproduce this is to remove
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ry Upgrading |
Fixes denoland#3153 (broken download_from_google_storage.py on macOS Catalina)
Fixes denoland#3153 (broken download_from_google_storage.py on macOS Catalina)
@jamiebuilds This should be fixed now with #3175. Could you retry with the latest master? |
@chrmoritz I found this issue after opening a new issue: #3440 the problem still seems to exist on |
Running:
Yields:
Full stack trace:
I did already have
depot_tools
cloned on my machine and setup in myPATH
but I removed it to see if there was some unusual conflict thereThe text was updated successfully, but these errors were encountered: