Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix depot_tools on macOS Catalina by upgrading it to 23247b9 #3441

Merged
merged 1 commit into from
Dec 4, 2019
Merged

fix depot_tools on macOS Catalina by upgrading it to 23247b9 #3441

merged 1 commit into from
Dec 4, 2019

Conversation

chrmoritz
Copy link
Contributor

@chrmoritz chrmoritz commented Dec 4, 2019 •
edited
Loading

The macOS Catalina fix floated over third_party/depot_tools in denoland/deno_third_party@818d33a got accidentally reverted in the v8 7.9.317.12 upgrade in denoland/deno_third_party@cab4821#diff-452661d791c32d03de51b6ef4c687bf1L47-R47. This breaks running ./tools/setup.py on a fresh clone on macOS Catalina again.

This PR finally fixes the issue by doing the full depot_tools upgrade to 23247b9 (the version used in v8 8.0). It also ports the required Windows virtualenv fixes from denoland/rusty_v8@7dbde4e#diff-e9f950f17198d3d5e3122a44230a09b9R33-R46 to the CI workflow, which prevented the upgrade the last time we tried it here in #3172.

Refs: denoland/deno_third_party#58
Fixes: #3440
Fixes: #3153

BTW: Also +4,311 −9,830 in third_party looks nice, however the virtualenv setup on Windows add a couple of seconds to the setup.py-step execution time.

This was referenced Dec 4, 2019
Merged
Closed
ry
ry approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks! LGTM

@ry ry merged commit 214b3eb into denoland:master Dec 4, 2019
@chrmoritz chrmoritz deleted the depotToolsFix branch December 4, 2019 23:34
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@chrmoritz @bartlomieju
fix depot_tools on macOS Catalina by upgrading it to 23247b9 (denolan…
7f345fa 
…d#3441)

Fixes: denoland#3440
Fixes: denoland#3153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macos catalina] build failures Can't build master
2 participants
@chrmoritz @ry