cherry-pick depot_tools 6a1d778 to fix macOS Cataliona issues #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3172, which just cherry-picks the relevant fix from
6a1d778todepot_toolsto fix the Catalina issues, while avoiding having to deal with the Windows virtualenv issues from a fulldepot_toolsupdate, see #3172.Goes with denoland/deno_third_party#54.
Verified locally that this is enough for fixing the
download_from_google_storage.pyon Catalina.See also: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/6a1d77869d77b61189247ce8b47ac9d86684a6c2
Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1012612