Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno repl hangs with excessive memory usage running from certain CWDs #18538

Closed
sepehrst opened this issue Mar 31, 2023 · 2 comments
Closed

deno repl hangs with excessive memory usage running from certain CWDs #18538

sepehrst opened this issue Mar 31, 2023 · 2 comments
Assignees
@dsherret
Labels
bug Something isn't working correctly high priority

Comments

@sepehrst
Copy link

sepehrst commented Mar 31, 2023 •
edited

OS: Windows 10 Version 10.0.19045.2728

From deno 1.32.1+7722014 and up, running deno repl or just deno from certain directories causes the deno process to hang with no repl prompt and with excessive memory usage.

The bug is reproducible if running deno from C:\, C:\Windows, C:\Users, C:\Users\<current_user>, C:\Windows\System32, C:\Windows\SysWow64. At the same time runinng deno repl from C:\Users\<current_user>\Desktop or C:\Windows\System32\wbem proceeds as normal. These are the directories that I've tested which reproduced the bug 100% of the times. Other directories and drives seems unaffected.

The last unaffected canary version with available binaries to download is deno 1.32.1+e888c3f

Edit:
Just checked with the 1.32.2 release. It's still affected.

Edit2:
Checked 1.32.2 Linux under Windows WSL, it hangs when executing with the root dir (/) as the current directory.
@sepehrst sepehrst mentioned this issue Mar 31, 2023
Merged
@dsherret dsherret mentioned this issue Apr 1, 2023
Closed
@dsherret dsherret added bug Something isn't working correctly high priority labels Apr 1, 2023
@roj1512
Copy link
Contributor

roj1512 commented Apr 1, 2023

Note that this occurs not only on Windows or WSL, but on Linux as well. #18540.

@dsherret dsherret self-assigned this Apr 1, 2023
@dsherret dsherret changed the title deno repl hangs with excessive memory usage running from certain CWDs on Windows deno repl hangs with excessive memory usage running from certain CWDs Apr 1, 2023
@dsherret dsherret mentioned this issue Apr 1, 2023
Merged
dsherret added a commit that referenced this issue Apr 1, 2023
@dsherret
fix(repl): disable language server document preloading in the repl (#…
bac8e4f 
…18543)

This was an oversight because the repl uses the language server under
the hood. Also, never preloads from a root directory.

Part of #18538
@dsherret dsherret mentioned this issue Apr 1, 2023
Merged
@dsherret
Copy link
Member

dsherret commented Apr 1, 2023 •
edited

Resolved by #18543 -- I'm going to do a release later today.

Edit: This is fixed now. Upgrade to 1.32.3

@dsherret dsherret closed this as completed Apr 1, 2023
dsherret added a commit that referenced this issue Apr 1, 2023
@dsherret
fix(lsp): add a document preload file system entry limit (#18553)
0210c1c 
I was testing this out and it's badly needed. For now, it's not
configurable and limited to 1,000 file system entries.

Related to #18538
dsherret added a commit that referenced this issue Apr 1, 2023
@dsherret
fix(repl): disable language server document preloading in the repl (#…
b1e2601 
…18543)

This was an oversight because the repl uses the language server under
the hood. Also, never preloads from a root directory.

Part of #18538
dsherret added a commit that referenced this issue Apr 1, 2023
@dsherret
fix(lsp): add a document preload file system entry limit (#18553)
cf3d38d 
I was testing this out and it's badly needed. For now, it's not
configurable and limited to 1,000 file system entries.

Related to #18538
This was referenced Apr 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working correctly high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsherret @sepehrst @roj1512