Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repl): disable language server document preloading in the repl #18543

Merged
merged 4 commits into from
Apr 1, 2023
Merged

fix(repl): disable language server document preloading in the repl #18543

merged 4 commits into from
Apr 1, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 1, 2023 •
edited
Loading

This was an oversight because the repl uses the language server under the hood. Also, never preloads from a root directory.

Part of #18538

lucacasonato
lucacasonato approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. LGTM

We should probably bail out on the server also if the number of documents exceeds some default threshold (with a config option to up the threshold).

bartlomieju
bartlomieju approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

I agree with Luca. Maybe we should limit to 1000 files by default?

@dsherret
Copy link
Member Author

dsherret commented Apr 1, 2023 •
edited
Loading

I'll make it have a max entry limit and change it to depth first search breadth-first search in an upcoming PR.

@dsherret dsherret merged commit bac8e4f into denoland:main Apr 1, 2023
@dsherret dsherret deleted the fix_disable_repl_preload branch April 1, 2023 16:02
@dsherret dsherret mentioned this pull request Apr 1, 2023
Closed
dsherret added a commit that referenced this pull request Apr 1, 2023
@dsherret
fix(repl): disable language server document preloading in the repl (#…
b1e2601 
…18543)

This was an oversight because the repl uses the language server under
the hood. Also, never preloads from a root directory.

Part of #18538
@albnnc albnnc mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @bartlomieju @lucacasonato