fix(lsp): add a document preload file system entry limit #18553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Apr 1, 2023
| return false; | ||
| } | ||
|
|
||
| // ignore cargo target directories for anyone using Deno with Rust |
There was a problem hiding this comment.
I think it's worth it to look for and handle these kind of scenarios.
bartlomieju
approved these changes
Apr 1, 2023
Comment on lines
+1679
to
+1686
| lsp_warn!( | ||
| concat!( | ||
| "Hit the language server document preload limit of {} file system entries. ", | ||
| "You may want to use the \"deno.enablePaths\" configuration setting to only have Deno ", | ||
| "partially enable a workspace." | ||
| ), | ||
| self.limit, | ||
| ); |
There was a problem hiding this comment.
Maybe in vscode_deno we could show a pop up if this message is printed?
There was a problem hiding this comment.
Let's iterate on this in the future. I'd have to refactor the code to get the lsp client here and perhaps some users might not like this message.
dsherret
added a commit
that referenced
this pull request
Apr 1, 2023
I was testing this out and it's badly needed. For now, it's not configurable and limited to 1,000 file system entries. Related to #18538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing this out and it's badly needed. For now, it's not configurable and limited to 1,000 file system entries.
Related to #18538