Adding filtering support for Weaviate when used for BM25 querying #4385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
We were waiting for Weaviate v1.18.0 to close a gap of functionality - lack of support for using filters with BM25 searching.
Version v1.18.0 just has been released and now it has this missing functionality, so I was uncommenting all the places where I left code in for the time when Weaviate starts supporting this.
How did you test it?
I have some local tests with some live data in Weaviate, plus there is also a unit test which was activated for the Weaviate BM25 search with filter scenario.
Notes for the reviewer
None
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.