Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filtering support for Weaviate when used for BM25 querying #4385

Merged

Conversation

zoltan-fedor
Copy link
Contributor

Related Issues

Proposed Changes:

We were waiting for Weaviate v1.18.0 to close a gap of functionality - lack of support for using filters with BM25 searching.
Version v1.18.0 just has been released and now it has this missing functionality, so I was uncommenting all the places where I left code in for the time when Weaviate starts supporting this.

How did you test it?

I have some local tests with some live data in Weaviate, plus there is also a unit test which was activated for the Weaviate BM25 search with filter scenario.

Notes for the reviewer

None

Checklist

  • [x I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🚀

@silvanocerza silvanocerza merged commit 32091d6 into deepset-ai:main Mar 29, 2023
@bobvanluijt
Copy link
Contributor

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable filtering with BM25 search in Weaviate now that it is supported with v1.18.0
3 participants