Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering with BM25 search in Weaviate now that it is supported with v1.18.0 #4384

Closed
zoltan-fedor opened this issue Mar 12, 2023 · 0 comments · Fixed by #4385
Closed
Assignees

Comments

@zoltan-fedor
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Filtering with BM25 search was not supported prior to Weaviate v1.18.0, but with this version now it is supported in Weaviate, so we need to support it from Haystack when the Weaviate document store is used.

Describe the solution you'd like
I have made comments in the code before regarding the places where changes need to be made once this becomes available in Weaviate, so now we just need to uncomment those to make this work.

Describe alternatives you've considered
N/A

Additional context
I will submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants