-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaviate: enable BM25 queries with filters #3553
Comments
Hi @masci, Unfortunately the filter support with BM25 is still NOT in Weaviate today (v1.16.5), as it was confirmed by testing and the Weaviate core devs. In July 2022 I have raised a Weaviate issue for this being added (see), but that just got re-raised by a Weaviate core dev today: weaviate/weaviate#2393 Please vote for this issue in Weaviate, so hopefully they can add the filter support for BM25 in Weaviate soon: Once that is added, then Haystack can be made to support that, but obv. not before that unfortunately. |
Hey @zoltan-fedor ! Thank you for the heads-up! There must be an issue with our test suite then. I'll perform some manual tests to see what's happening. |
Hey @ZanSara, But in summary there were two issues:
|
FYI - thanks to support shown by the community the Weaviate dev team has just scheduled the delivery of this functionality (filter support for BM25 search) for |
@zoltan-fedor thanks a lot for reaching out with all these detailed reports! Together with @ZanSara we traced back the problem, a bit crazy how this happened with several tiny mistakes lining up perfectly to cause a bigger one. On a positive note, it's great to see the Haystack community in action 🙌 |
As 1.18 is out, I wanted to give this some activity. Would this work now @zoltan-fedor ? |
Ah okay, I found https://github.com/deepset-ai/haystack/pull/4385/files#diff-d4e4f2566db6c2fbe852debffcf7830447ecb969d4cdcce6d796fd773eba379b, so I guess this is solved then as well? |
@krlng, |
done in #4385 |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When BM25 support was firstly introduced in 1.14, Weaviate didn't support passing filters along with the query and Haystack raises an exception when you call
query()
with both a query text and some filters.Describe the solution you'd like
This is now supported in 1.16 and we should amend this part of the code
haystack/haystack/document_stores/weaviate.py
Lines 989 to 997 in 005025b
The text was updated successfully, but these errors were encountered: