Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubocop convention offenses #4597

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix rubocop convention offenses #4597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/system/advanced_search_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@

scenario "Search by multiple filters" do
Setting["official_level_1_name"] = "Official position 1"
ana = create :user, official_level: 1
ana = create :user, official_level: 1
john = create :user, official_level: 1

create(:budget_investment, heading: heading, title: "Get Schwifty", author: ana, created_at: 1.minute.ago)
Expand Down
2 changes: 1 addition & 1 deletion spec/system/budgets/investments_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def investments_order

fill_in "Title", with: "I am a bot"
fill_in_ckeditor "Description", with: "This is the description"
check "budget_investment_terms_of_service"
check "budget_investment_terms_of_service"

click_button "Create Investment"

Expand Down
8 changes: 4 additions & 4 deletions spec/system/emails_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,17 +342,17 @@
end

context "Budgets" do
let(:author) { create(:user, :level_two) }
let(:budget) { create(:budget) }
let!(:heading) { create(:budget_heading, name: "More hospitals", budget: budget) }
let(:author) { create(:user, :level_two) }
let(:budget) { create(:budget) }
before { create(:budget_heading, name: "More hospitals", budget: budget) }

scenario "Investment created" do
login_as(author)
visit new_budget_investment_path(budget_id: budget.id)

fill_in "Title", with: "Build a hospital"
fill_in_ckeditor "Description", with: "We have lots of people that require medical attention"
check "budget_investment_terms_of_service"
check "budget_investment_terms_of_service"

click_button "Create Investment"
expect(page).to have_content "Investment created successfully"
Expand Down