Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop convention offenses #4597

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix rubocop convention offenses #4597

merged 1 commit into from
Aug 9, 2021

Commits on Aug 9, 2021

  1. Fix rubocop convention offenses

    While we use Pronto to detect offenses in the lines changed in our pull
    request, sometimes our changes introduce offenses in other lines, and we
    don't detect them.
    
    In commit 0488b37, we removed the only usage of the `heading` method
    in a test, which caused a `RSpec/LetSetup` offense.
    
    In commit 287c488, we changed some lines from `fill_in` to
    `fill_in_ckeditor`. Some of these lines were aligned with the following
    ones, which after that change had extra spacing for no reason.
    
    Finally, in commit 8d38ed5 we added a line before two lines which had
    their equals signs aligned. Since, after adding this line, the block was
    no longer aligned, there was no reason for the extra space in one of the
    lines.
    javierm committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    afb660f View commit details
    Browse the repository at this point in the history