Fix rubocop convention offenses #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
rubocop_offenses
branch
from
1f7a121
to
afb660f
Compare
While we use Pronto to detect offenses in the lines changed in our pull request, sometimes our changes introduce offenses in other lines, and we don't detect them. In commit 0488b37, we removed the only usage of the `heading` method in a test, which caused a `RSpec/LetSetup` offense. In commit 287c488, we changed some lines from `fill_in` to `fill_in_ckeditor`. Some of these lines were aligned with the following ones, which after that change had extra spacing for no reason. Finally, in commit 8d38ed5 we added a line before two lines which had their equals signs aligned. Since, after adding this line, the block was no longer aligned, there was no reason for the extra space in one of the lines.
taitus
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
While we use Pronto to detect offenses in the lines changed in our pull requests, sometimes our changes introduce offenses in other lines, and we don't detect them.
Objectives