Use find instead of find by #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some custom routes created using the param[:id] but the Rails routes use the param[:budget_id] by default, so the same controller could be asked for different param keys.
Make it easier to find by slug or id for sluggable models. It will raise a 404 HTML Not found error if the resource is not found.
houndci-bot
reviewed
Jun 3, 2019
| @@ -40,7 +87,7 @@ | |||
| investments.each do |investment| | |||
| within("#budget-investments") do | |||
| expect(page).to have_content investment.title | |||
| expect(page).to have_css("a[href='#{budget_investment_path(budget_id: budget.id, id: investment.id)}']", text: investment.title) | |||
| expect(page).to have_css("a[href='#{budget_investment_path(budget, id: investment.id)}']", text: investment.title) | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [122/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Better raise a 404 HTML NotFound exception than any other unexpected error.
javierm
force-pushed
the
use_find_instead_of_find_by_id
branch
from
4cf0148
to
b122302
Compare
microweb10
approved these changes
Jun 4, 2019
voodoorai2000
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
find(id)instead offind_by(id: id). It's preferable to raise a 404 HTML error than any other unexpected/unknown Exception.find_by_slug_or_idandfind_by_slug_or_id!to the moduleSluggableto make it easier to add these methods other models.